Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpc/dhcp_options: Fix panic #39427

Merged
merged 2 commits into from
Sep 20, 2024
Merged

vpc/dhcp_options: Fix panic #39427

merged 2 commits into from
Sep 20, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 20, 2024 •
edited
Loading

Description

Relations

Closes #39343

References

Output from Acceptance Testing

% make t T=TestAccVPCDHCPOptions_ K=vpc P=14
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ec2/... -v -count 1 -parallel 14 -run='TestAccVPCDHCPOptions_'  -timeout 360m
=== RUN   TestAccVPCDHCPOptions_basic
=== PAUSE TestAccVPCDHCPOptions_basic
=== RUN   TestAccVPCDHCPOptions_full
=== PAUSE TestAccVPCDHCPOptions_full
=== RUN   TestAccVPCDHCPOptions_tags
=== PAUSE TestAccVPCDHCPOptions_tags
=== RUN   TestAccVPCDHCPOptions_disappears
=== PAUSE TestAccVPCDHCPOptions_disappears
=== CONT  TestAccVPCDHCPOptions_basic
=== CONT  TestAccVPCDHCPOptions_tags
=== CONT  TestAccVPCDHCPOptions_disappears
=== CONT  TestAccVPCDHCPOptions_full
--- PASS: TestAccVPCDHCPOptions_disappears (17.05s)
--- PASS: TestAccVPCDHCPOptions_basic (19.54s)
--- PASS: TestAccVPCDHCPOptions_full (19.55s)
--- PASS: TestAccVPCDHCPOptions_tags (40.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	45.780s

@YakDriver YakDriver requested a review from a team as a code owner September 20, 2024 18:52
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 20, 2024
@ewbankkit ewbankkit self-assigned this Sep 20, 2024
ewbankkit
ewbankkit approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCDHCPOptions' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCDHCPOptions -timeout 360m
=== RUN   TestAccVPCDHCPOptionsAssociation_basic
=== PAUSE TestAccVPCDHCPOptionsAssociation_basic
=== RUN   TestAccVPCDHCPOptionsAssociation_Disappears_vpc
=== PAUSE TestAccVPCDHCPOptionsAssociation_Disappears_vpc
=== RUN   TestAccVPCDHCPOptionsAssociation_Disappears_dhcp
=== PAUSE TestAccVPCDHCPOptionsAssociation_Disappears_dhcp
=== RUN   TestAccVPCDHCPOptionsAssociation_disappears
=== PAUSE TestAccVPCDHCPOptionsAssociation_disappears
=== RUN   TestAccVPCDHCPOptionsAssociation_default
=== PAUSE TestAccVPCDHCPOptionsAssociation_default
=== RUN   TestAccVPCDHCPOptionsDataSource_basic
=== PAUSE TestAccVPCDHCPOptionsDataSource_basic
=== RUN   TestAccVPCDHCPOptionsDataSource_filter
=== PAUSE TestAccVPCDHCPOptionsDataSource_filter
=== RUN   TestAccVPCDHCPOptions_basic
=== PAUSE TestAccVPCDHCPOptions_basic
=== RUN   TestAccVPCDHCPOptions_full
=== PAUSE TestAccVPCDHCPOptions_full
=== RUN   TestAccVPCDHCPOptions_tags
=== PAUSE TestAccVPCDHCPOptions_tags
=== RUN   TestAccVPCDHCPOptions_disappears
=== PAUSE TestAccVPCDHCPOptions_disappears
=== CONT  TestAccVPCDHCPOptionsAssociation_basic
=== CONT  TestAccVPCDHCPOptionsDataSource_filter
=== CONT  TestAccVPCDHCPOptions_tags
--- PASS: TestAccVPCDHCPOptionsAssociation_basic (17.68s)
=== CONT  TestAccVPCDHCPOptionsAssociation_disappears
--- PASS: TestAccVPCDHCPOptionsDataSource_filter (19.71s)
=== CONT  TestAccVPCDHCPOptionsDataSource_basic
--- PASS: TestAccVPCDHCPOptions_tags (31.00s)
=== CONT  TestAccVPCDHCPOptionsAssociation_default
--- PASS: TestAccVPCDHCPOptionsDataSource_basic (13.57s)
=== CONT  TestAccVPCDHCPOptions_disappears
--- PASS: TestAccVPCDHCPOptionsAssociation_disappears (16.27s)
=== CONT  TestAccVPCDHCPOptions_full
--- PASS: TestAccVPCDHCPOptions_disappears (21.50s)
=== CONT  TestAccVPCDHCPOptionsAssociation_Disappears_dhcp
--- PASS: TestAccVPCDHCPOptions_full (24.05s)
=== CONT  TestAccVPCDHCPOptionsAssociation_Disappears_vpc
--- PASS: TestAccVPCDHCPOptionsAssociation_default (28.73s)
=== CONT  TestAccVPCDHCPOptions_basic
--- PASS: TestAccVPCDHCPOptionsAssociation_Disappears_dhcp (20.49s)
--- PASS: TestAccVPCDHCPOptionsAssociation_Disappears_vpc (18.47s)
--- PASS: TestAccVPCDHCPOptions_basic (17.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	82.830s

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Sep 20, 2024
@YakDriver YakDriver merged commit 14e2fd8 into main Sep 20, 2024
57 checks passed
@YakDriver YakDriver deleted the b-vpc-dhcp-options-panic branch September 20, 2024 21:08
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 20, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 20, 2024
Update CHANGELOG.md for #39427
a4baf15
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/vpc Issues and PRs that pertain to the vpc service.
Projects
None yet
Milestone
v5.69.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: The terraform-provider-aws_v5.65.0_x5 plugin crashed!
2 participants
@YakDriver @ewbankkit